Skip to content

fix: correct remote file picker dropdown chevron alignment #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Jun 26, 2025

There appears to be a bug when a View created using NSView is inside a DisclosureGroup label - regardless of the size of the NSView, it breaks the alignment of the chevron that's included on the DisclosureGroup label by default:

In #184 we added an NSView to the spinner, causing this issue.

This is almost certainly a SwiftUI bug, and so we'll work around it by placing the spinner and error symbol to the right of the label by just setting a trailing padding on the text.
The end result (with spinners on):

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson marked this pull request as ready for review June 26, 2025 04:51
@ethanndickson ethanndickson self-assigned this Jul 1, 2025
@ethanndickson ethanndickson requested a review from matifali July 7, 2025 04:16
Copy link
Member Author

ethanndickson commented Jul 9, 2025

Merge activity

  • Jul 9, 10:00 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 9, 10:00 AM UTC: @ethanndickson merged this pull request with Graphite.

@ethanndickson ethanndickson merged commit 15f1890 into main Jul 9, 2025
4 checks passed
@ethanndickson ethanndickson deleted the ethan/file-picker-chevron-alignment branch July 9, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants